Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Add missing include (gcc13.2/clang17 build) #4348

Merged
merged 1 commit into from Nov 28, 2023
Merged

COMP: Add missing include (gcc13.2/clang17 build) #4348

merged 1 commit into from Nov 28, 2023

Conversation

codeling
Copy link
Contributor

Fixes build on gcc 13.2 and clang 17 (tested on Fedora 39), see also https://discourse.itk.org/t/build-error-with-g-13-2

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

@github-actions github-actions bot added type:Compiler Compiler support or related warnings area:Core Issues affecting the Core module labels Nov 28, 2023
@phcerdan phcerdan self-requested a review November 28, 2023 09:05
phcerdan
phcerdan approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@phcerdan phcerdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@dzenanz dzenanz merged commit f871250 into InsightSoftwareConsortium:master Nov 28, 2023
10 of 11 checks passed
@codeling codeling deleted the NewestGccClangBuildFix branch November 29, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@phcerdan phcerdan phcerdan approved these changes

Assignees
No one assigned
Labels
area:Core Issues affecting the Core module type:Compiler Compiler support or related warnings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codeling @dzenanz @phcerdan