Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE: Fix style in miscellaneous FEM tests #4418

Merged

Conversation

jhlegarreta
Copy link
Member

  • STYLE: Remove commented statements with hard-coded filenames in FEM
  • STYLE: Start reader/writer FEM module local variables with lowercase

PR Checklist

Remove commented statements containing hard-coded filenames in `FEM`
module: all relevant filenames are being provided through the
corresponding `CMakeLists.txt` testing command arguments.
Start reader/writer `FEM` module local variables with lowercase as per
ITK style guidelines.
@github-actions github-actions bot added type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct type:Style Style changes: no logic impact (indentation, comments, naming) area:Numerics Issues affecting the Numerics module labels Jan 21, 2024
@jhlegarreta
Copy link
Member Author

A few comments:

@hjmjohnson hjmjohnson merged commit d3cc874 into InsightSoftwareConsortium:master Jan 22, 2024
12 checks passed
@jhlegarreta jhlegarreta deleted the FixFEMMiscTestsStyle branch January 22, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Numerics Issues affecting the Numerics module type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants