Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Wrap CompositeTransform for float32 parameters #4444

Merged
merged 2 commits into from Feb 3, 2024
Merged

ENH: Wrap CompositeTransform for float32 parameters #4444

merged 2 commits into from Feb 3, 2024

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Feb 2, 2024

For the use case of a float32 displacement vector field.

@thewtex
Copy link
Member Author

thewtex commented Feb 2, 2024

Re: https://discourse.itk.org/t/itk-python-image-of-itk-d-vectors-for-composite-transform/5122

@github-actions github-actions bot added type:Enhancement Improvement of existing methods or implementation area:Python wrapping Python bindings for a class area:Core Issues affecting the Core module labels Feb 2, 2024
@thewtex thewtex requested a review from dzenanz February 2, 2024 15:25
@PranjalSahu
Copy link
Contributor

Build failing with warning message:
itkCompositeTransform: warning(4): ITK type not wrapped, or currently not known: itk::MultiTransform< float, 2 >

@thewtex @dzenanz
ENH: Wrap CompositeTransform for float32 parameters
a7f0f8a 
For the use case of a float32 displacement vector field.
@dzenanz
Copy link
Member

dzenanz commented Feb 2, 2024

I amended it with addition for MultiTransform.

@dzenanz
ENH: Wrap DataObjectDecorator<CompositeTransform<float>>
03c426a 
Addresses:

itkANTSRegistration: warning(4): ITK type not wrapped, or currently not known: itk::DataObjectDecorator< itk::CompositeTransform< float, 2 > >
itkANTSRegistration: warning(4): ITK type not wrapped, or currently not known: itk::DataObjectDecorator< itk::CompositeTransform< float, 3 > >
@github-actions github-actions bot added the area:Registration Issues affecting the Registration module label Feb 2, 2024
PranjalSahu
PranjalSahu approved these changes Feb 3, 2024
View reviewed changes
Copy link
Contributor

@PranjalSahu PranjalSahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzenanz dzenanz merged commit b6a6b6b into InsightSoftwareConsortium:master Feb 3, 2024
12 checks passed
@dzenanz dzenanz mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PranjalSahu PranjalSahu PranjalSahu approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
area:Core Issues affecting the Core module area:Python wrapping Python bindings for a class area:Registration Issues affecting the Registration module type:Enhancement Improvement of existing methods or implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thewtex @PranjalSahu @dzenanz