STYLE: Improve ivar printing in PrintSelf methods
#4763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Filtering
|
Realized about these when resuming work on #3908. By no means this PR is intended to be extensive in the changes: separate, incremental PRs as code is inspected can be done. |
jhlegarreta
force-pushed
the
MiscClassesPrintSelfImprovements
branch
4 times, most recently
from
8f498c3
to
1039e0b
Compare
|
/azp ITK.macOS |
jhlegarreta
changed the title
PrintSelf methodsPrintSelf methods
jhlegarreta
force-pushed
the
MiscClassesPrintSelfImprovements
branch
2 times, most recently
from
e67f925
to
9d72316
Compare
|
Tests are passing: https://open.cdash.org/viewBuildError.php?type=1&buildid=9723501 Same applies to |
thewtex
approved these changes
Jun 29, 2024
2 tasks
dzenanz
approved these changes
Jul 1, 2024
|
@jhlegarreta Can you please rebase on the recent master branch? |
Improve ivar printing in `PrintSelf` methods:
- Use the `itkPrintSelfObjectMacro` macro to avoid boilerplate code when
printing smart pointers/objects that can be null pointers.
- Rely on the enum classes ostream insertion operator overload to
directly print such variables. Avoid boilerplate code.
- Increase consistency when printing boolean ivars: use the
`({ivar} ? "On" : "Off")` recipe in agreement with the ITK SW Guide.
- Do not check whether `std::string` types ivars are empty to
conditionally print their contents; rely on the ostream insertion
operator overload to print the appropriate content.
- Print the member variable names verbatim to conform to the ITK SW
Guide.
- Prefer using `std::endl` instead of `\n` to add a new line for the
sake of consistency.
Take advantage of the commit to print ivars that had been missed in the
modified classes.
jhlegarreta
force-pushed
the
MiscClassesPrintSelfImprovements
branch
from
9d72316
to
ee5fbe7
Compare
Done. |
|
/azp run ITK.Windows |
hjmjohnson
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve ivar printing in
PrintSelfmethods:itkPrintSelfObjectMacromacro to avoid boilerplate code when printing smart pointers/objects that can be null pointers.({ivar} ? "On" : "Off")recipe in agreement with the ITK SW Guide.std::stringtypes ivars are empty to conditionally print their contents; rely on the ostream insertion operator overload to print the appropriate content.std::endlinstead of\nto add a new line for the sake of consistency.Take advantage of the commit to print ivars that had been missed in the modified classes.
PR Checklist