Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Bump elastix version to 2022-12-07 #179

Conversation

N-Dekker
Copy link
Collaborator

@N-Dekker N-Dekker commented Nov 23, 2022

Including:

pull request SuperElastix/elastix#770
commit SuperElastix/elastix@c0262ba
"ENH: Add CMake options to not install artifacts", by Matt McCormick (@thewtex)

pull request SuperElastix/elastix#767
"ElastixRegistrationMethod transform objects", adding:

  • ElastixRegistrationMethod::GetCombinationTransform()
  • TransformixFilter::SetCombinationTransform(transform)
  • ElastixRegistrationMethod::GetNumberOfTransforms()
  • ElastixRegistrationMethod::GetNthTransform(n)
  • ElastixRegistrationMethod::ConvertToItkTransform(transform)

pull request SuperElastix/elastix#755
commit SuperElastix/elastix@7fe8ed9
"ENH: Add TransformixFilter SpatialJacobian, DeterminantOfSpatialJacobian"

@N-Dekker N-Dekker force-pushed the Bump-elastix-version-to-2022-11-23 branch from a02baa0 to 7e0edfd Compare November 28, 2022 11:12
@N-Dekker N-Dekker force-pushed the Bump-elastix-version-to-2022-11-23 branch from 7e0edfd to 183ec38 Compare December 7, 2022 09:38
@N-Dekker N-Dekker changed the title ENH: Bump elastix version to 2022-11-23 ENH: Bump elastix version to 2022-12-07 Dec 7, 2022
@N-Dekker N-Dekker force-pushed the Bump-elastix-version-to-2022-11-23 branch from 183ec38 to d070481 Compare December 7, 2022 09:41
@N-Dekker
Copy link
Collaborator Author

N-Dekker commented Dec 7, 2022

I see some errors at the CI from Notebook tests / Run notebooks on treebeard (pull_request) saying:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
voila 0.4.0 requires nbclient<0.8,>=0.4.0, but you have nbclient 0.3.1 which is incompatible.
nbconvert 7.2.6 requires nbclient>=0.5.0, but you have nbclient 0.3.1 which is incompatible.

examples/ITK_UnitTestExample3_BsplineRegistration.ipynb
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

Any suggestion how to fix these?

@thewtex
Copy link
Member

thewtex commented Dec 7, 2022

@N-Dekker thanks for these updates!

I will update the notebook CI and package in another PR, then we case rebase and the issue will be resolved or we will be able to get more information on the behavior either in CI or locally.

@N-Dekker N-Dekker force-pushed the Bump-elastix-version-to-2022-11-23 branch 2 times, most recently from e424db1 to 35bcfef Compare December 13, 2022 14:55
@N-Dekker
Copy link
Collaborator Author

The CI didn't run!

Including:

pull request SuperElastix/elastix#770
commit SuperElastix/elastix@c0262ba
"ENH: Add CMake options to not install artifacts", by Matt McCormick

pull request SuperElastix/elastix#767
"ElastixRegistrationMethod transform objects", adding:

 - ElastixRegistrationMethod::GetCombinationTransform()
 - TransformixFilter::SetCombinationTransform(transform)
 - ElastixRegistrationMethod::GetNumberOfTransforms()
 - ElastixRegistrationMethod::GetNthTransform(n)
 - ElastixRegistrationMethod::ConvertToItkTransform(transform)

pull request SuperElastix/elastix#755
commit SuperElastix/elastix@7fe8ed9
"ENH: Add TransformixFilter SpatialJacobian, DeterminantOfSpatialJacobian"
@N-Dekker N-Dekker force-pushed the Bump-elastix-version-to-2022-11-23 branch from 35bcfef to 7c00af9 Compare December 14, 2022 14:20
@thewtex
Copy link
Member

thewtex commented Dec 15, 2022

@N-Dekker can this PR be marked Ready for review? That may enable CI.

@N-Dekker N-Dekker marked this pull request as ready for review December 15, 2022 09:11
@thewtex
Copy link
Member

thewtex commented Dec 15, 2022

Lazy CI :-(

Let's merge and get a build going. I will rebase #186

@thewtex thewtex merged commit 9755735 into InsightSoftwareConsortium:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants