Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformix extras #82

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Transformix extras #82

merged 2 commits into from
Nov 17, 2020

Conversation

ViktorvdValk
Copy link
Collaborator

  • Outputs the deformation field.

  • The jacobian and it's derivative are given in a tuple, but still use disk IO, so solution is temporary, but works.

@ViktorvdValk
Copy link
Collaborator Author

ViktorvdValk commented Nov 10, 2020

The notebook tests will pass if the new notebooks files are merged, but I wanted to keep the pull requests separate.
See exampleNotebooks branch

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ViktorvdValk looks great! 🥇

We have a few macOS warnings in elastix:

https://open.cdash.org/viewBuildError.php?type=1&buildid=6869971

@N-Dekker any ideas on the best C++ approach to address those?

@N-Dekker
Copy link
Collaborator

We have a few macOS warnings in elastix:
https://open.cdash.org/viewBuildError.php?type=1&buildid=6869971
@N-Dekker any ideas on the best C++ approach to address those?

Thanks for asking @thewtex I made it an "issue": SuperElastix/elastix#355 I'm preparing a fix now.

@ViktorvdValk ViktorvdValk merged commit a7d2454 into master Nov 17, 2020
@ViktorvdValk ViktorvdValk deleted the transformix_extras branch November 19, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants