-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Avoid TravisCI build timeouts. #87
ENH: Avoid TravisCI build timeouts. #87
Conversation
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should still use macpython-download-cache-and-build-wheels.sh
. It passes through its arguments to macpython-build-module-wheels.sh
. This is what the "$@"
does here:
5116a9b
to
09cf1ac
Compare
Thank Matt. Let's see what the new build says. |
Looks like Python 3.6 and 3.7 are also being installed 😔. |
.travis.yml
Outdated
@@ -11,5 +11,6 @@ script: | |||
- curl -L https://rawgit.com/InsightSoftwareConsortium/ITKPythonPackage/master/scripts/macpython-download-cache-and-build-module-wheels.sh -O | |||
- chmod u+x macpython-download-cache-and-build-module-wheels.sh | |||
- ./macpython-download-cache-and-build-module-wheels.sh | |||
- ./macpython-build-module-wheels.sh 2.7 3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhlegarreta remove this line add add the version specification to the line above, i.e.
/macpython-download-cache-and-build-module-wheels.sh 2.7 3.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 81eac07. Let's see if this makes the build timeout go away. Thanks Matt.
Avoid TravisCI build timeouts by restricting the Python package builds to Python versions 2.7 and 3.5.
09cf1ac
to
81eac07
Compare
Hooray, Travis CI is green 👌 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @jhlegarreta 👍 LGTM
✨ thanks @jhlegarreta! |
Avoid TravisCI build timeouts by restricting the Python package builds to
Python versions 2.7 and 3.5.