Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Avoid TravisCI build timeouts. #87

Conversation

jhlegarreta
Copy link
Member

Avoid TravisCI build timeouts by restricting the Python package builds to
Python versions 2.7 and 3.5.

@jhlegarreta
Copy link
Member Author

The macpython-build-module-wheels.sh script does not seem to exist. Any idea why or where does it look for it @thewtex ?

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should still use macpython-download-cache-and-build-wheels.sh. It passes through its arguments to macpython-build-module-wheels.sh. This is what the "$@" does here:

https://github.com/InsightSoftwareConsortium/ITKPythonPackage/blob/master/scripts/macpython-download-cache-and-build-module-wheels.sh#L15

@jhlegarreta
Copy link
Member Author

Thank Matt. Let's see what the new build says.

@jhlegarreta
Copy link
Member Author

Looks like Python 3.6 and 3.7 are also being installed 😔.

.travis.yml Outdated
@@ -11,5 +11,6 @@ script:
- curl -L https://rawgit.com/InsightSoftwareConsortium/ITKPythonPackage/master/scripts/macpython-download-cache-and-build-module-wheels.sh -O
- chmod u+x macpython-download-cache-and-build-module-wheels.sh
- ./macpython-download-cache-and-build-module-wheels.sh
- ./macpython-build-module-wheels.sh 2.7 3.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhlegarreta remove this line add add the version specification to the line above, i.e.

/macpython-download-cache-and-build-module-wheels.sh 2.7 3.5

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 81eac07. Let's see if this makes the build timeout go away. Thanks Matt.

Avoid TravisCI build timeouts by restricting the Python package builds to
Python versions 2.7 and 3.5.
@jhlegarreta
Copy link
Member Author

Hooray, Travis CI is green 👌 .

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @jhlegarreta 👍 LGTM

@phcerdan
Copy link
Collaborator

✨ thanks @jhlegarreta!

@phcerdan phcerdan merged commit da32729 into InsightSoftwareConsortium:master Sep 24, 2018
@jhlegarreta jhlegarreta deleted the AvoidTravisCIBuildTimeout branch September 24, 2018 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants