Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update ITK Python package git commit hash in build, test workflow #157

Conversation

jhlegarreta
Copy link
Member

Update the ITK Python package git commit hash in the build, test GitHub actions workflow file for both the project itself and the cookiecutter module template file.

@jhlegarreta
Copy link
Member Author

jhlegarreta commented Feb 17, 2024

Updating the cookiecutter not done yet: depends on
InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#76

Done in 8912a0d.

Update the ITK Python package git commit hash in the build, test GitHub
actions workflow file for both the project itself and the cookiecutter
module template file.
@jhlegarreta
Copy link
Member Author

Despite Linux Python packages reporting a successful outcome, there are errors in the build, e.g.
https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/actions/runs/7962302110/job/21735464511?pr=157#step:9:663

that seem to be related to the std library and the compiler (?).

They were not present in the main builds, e.g.:
https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/actions/runs/7467310771/job/20320558474

They are not present in non-Python builds, but the errors stem from an #include <string> statement in itkMacro.h, which should be compiled in non-Python builds as well.

The macOS Python package failure seems to be related to a path not being found, and it looks like that path corresponds to a mismatched Python version:
https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/actions/runs/7962302110/job/21735463852?pr=157#step:8:1505

@jhlegarreta
Copy link
Member Author

Superseded by PR #158. Probably fixes to the ITKRemoteModuleBuildTestPackageAction and ITKPythonPackage repositories also helped. Closing as no longer relevant.

@jhlegarreta jhlegarreta deleted the UpdateITKPythonPackageGitHash branch April 22, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant