Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Bump skbuild to 0.16.2 to resolve Windows build failures #229

Merged
merged 1 commit into from Nov 28, 2022

Conversation

tbirdso
Copy link
Contributor

@tbirdso tbirdso commented Nov 28, 2022

Addresses ITK module issue detailed in scikit-build/scikit-build#805

Will validate with experimental ITKRemoteModuleBuildPackageAction/ITKSplitComponents CI prior to merge

@tbirdso
Copy link
Contributor Author

tbirdso commented Nov 28, 2022

CI is passing: https://github.com/InsightSoftwareConsortium/ITKSplitComponents/actions/runs/3568248026

As ITKPythonPackage is already tagged for v5.3 I will add a new step in ITKRemoteModuleBuildPackageAction for consuming an optional ITKPythonPackage commit other than the one included in ITKPythonBuilds archives.

@tbirdso tbirdso merged commit 0f5effc into master Nov 28, 2022
@dzenanz dzenanz deleted the bump-skbuild branch December 1, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants