Python 3.12 #259
Merged
Python 3.12 #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also drop the Python 3.7 install, which is End Of Life.
tbirdso
approved these changes
Oct 3, 2023
scripts/macpython-install-python.sh
Outdated
Comment on lines
416
to
419
| #for pyversion in $LATEST_3p7; do | ||
| #install_macpython $pyversion 10.9 | ||
| #install_virtualenv | ||
| #done |
There was a problem hiding this comment.
I thought it would be helpful to leave as a reminder that 3.7 is associated with 10.9.
There was a problem hiding this comment.
Ah, I didn't catch that. Would you please add a one-line comment to that effect?
There was a problem hiding this comment.
Added per @jcfr 's inline suggestion.
dzenanz
approved these changes
Oct 3, 2023
jcfr
reviewed
Oct 3, 2023
jcfr
approved these changes
Oct 3, 2023
jcfr
reviewed
Oct 3, 2023
| @@ -39,11 +39,11 @@ TARGET_ARCH=${TARGET_ARCH:=x64} | |||
|
|
|||
| # Specialized manylinux image tag to use for building. | |||
| if [[ ${MANYLINUX_VERSION} == _2_28 && ${TARGET_ARCH} == x64 ]]; then | |||
| IMAGE_TAG=${IMAGE_TAG:=20230106-1aeaea0} | |||
| IMAGE_TAG=${IMAGE_TAG:=20230926-9eb419c} | |||
| elif [[ ${MANYLINUX_VERSION} == _2_28 && ${TARGET_ARCH} == aarch64 ]]; then | |||
| IMAGE_TAG=${IMAGE_TAG:=2022-11-19-1b19e81} | |||
There was a problem hiding this comment.
Should this one be updated as well ?
There was a problem hiding this comment.
This one is currently separate as we work towards arm cross-compilation.
jcfr
reviewed
Oct 3, 2023
| elif [[ ${MANYLINUX_VERSION} == _2_28 && ${TARGET_ARCH} == aarch64 ]]; then | ||
| IMAGE_TAG=${IMAGE_TAG:=2022-11-19-1b19e81} | ||
| elif [[ ${MANYLINUX_VERSION} == 2014 ]]; then | ||
| IMAGE_TAG=${IMAGE_TAG:=20230106-1aeaea0} | ||
| IMAGE_TAG=${IMAGE_TAG:=20230926-9eb419c} |
There was a problem hiding this comment.
For future reference, the associated dockcross changes are the following: https://github.com/dockcross/dockcross/compare/1aeaea0..9eb419c
Summary:
- CMake
3.24.2->3.27.5 - Ninja
1.11.0->1.11.1 - Git
2.36.1->2.42.0 - Manylinux
2.28- Update toolset from
gcc-toolset-11togcc-toolset-12 pypa/manylinux_2_28_x86_64:2022-11-19-1b19e81->quay.io/pypa/manylinux_2_28_x86_64:2022-11-28-5d13db4
- Update toolset from
- Manylinux
2014pypa/manylinux2014_x86_64:2022-11-28-5d13db4->pypa/manylinux2014_x86_64:2023-08-27-bd7ad21
Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.