Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extraction of itk group name #262

Merged

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Oct 17, 2023

No description provided.

Fix parsing of itk-module.cmake file to account for change introduced
in InsightSoftwareConsortium/ITK@efa749515 (STYLE: Initial run of
cmake-format) by implementing change similar to
InsightSoftwareConsortium/ITK@6384cd067 (BUG: Fix ITKGroup identification with multiline itk_module)
Follow-up of InsightSoftwareConsortium/ITKPythonPackage@00614a205 (Add
support for building one ITK wheel per "group") where the macro was originally
introduced by never used.
@jcfr jcfr linked an issue Oct 17, 2023 that may be closed by this pull request
@jcfr

This comment was marked as resolved.

@jcfr

This comment was marked as resolved.

@jcfr

This comment was marked as resolved.

@jcfr jcfr requested a review from thewtex October 17, 2023 18:36
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 @jcfr awesome, thank you!

@thewtex thewtex merged commit ae9d842 into InsightSoftwareConsortium:master Oct 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wheels are empty
2 participants