Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Bump version to 5.4rc4 #273

Merged
merged 2 commits into from Apr 17, 2024
Merged

ENH: Bump version to 5.4rc4 #273

merged 2 commits into from Apr 17, 2024

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Apr 16, 2024

ITK_GIT_TAG updated to tentative hash for v5.4rc04 tag.

ITK_GIT_TAG updated to tentative hash for v5.4rc04 tag.
@dzenanz
Copy link
Member

dzenanz commented Apr 16, 2024

If clang-format version is going to be updated, should that be done before the RC? It is a big-ish change, and doing it right before the final release is maybe not the best.

The `itk` meta wheel does not have native binaries, its file name is
`itk-*`. All the platform wheels are `itk_*`.

To address:

Traceback (most recent call last):
  File "/Users/svc-dashboard/D/P/ITKPythonPackage/scripts/../venvs/3.10/bin/delocate-wheel", line 8, in <module>
    sys.exit(main())
  File "/Users/svc-dashboard/D/P/ITKPythonPackage/venvs/3.10/lib/python3.10/site-packages/delocate/cmd/delocate_wheel.py", line 110, in main
    copied = delocate_wheel(
  File "/Users/svc-dashboard/D/P/ITKPythonPackage/venvs/3.10/lib/python3.10/site-packages/delocate/delocating.py", line 1004, in delocate_wheel
    out_wheel_fixed = _check_and_update_wheel_name(
  File "/Users/svc-dashboard/D/P/ITKPythonPackage/venvs/3.10/lib/python3.10/site-packages/delocate/delocating.py", line 831, in _check_and_update_wheel_name
    new_name, problematic_files = _calculate_minimum_wheel_name(
  File "/Users/svc-dashboard/D/P/ITKPythonPackage/venvs/3.10/lib/python3.10/site-packages/delocate/delocating.py", line 798, in _calculate_minimum_wheel_name
    raise DelocationError(
delocate.libsana.DelocationError: Failed to find any binary with the required architecture: 'x86_64'
@thewtex
Copy link
Member Author

thewtex commented Apr 16, 2024

If clang-format version is going to be updated, should that be done before the RC? It is a big-ish change, and doing it right before the final release is maybe not the best.

No, that should come after v5.4.0.

@thewtex thewtex merged commit e37dd9b into master Apr 17, 2024
1 check passed
@thewtex thewtex deleted the itk-v5.4rc04 branch April 17, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants