Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Docker 2014 image download failure is silent #24

Open
1 of 2 tasks
tbirdso opened this issue Dec 7, 2022 · 2 comments
Open
1 of 2 tasks

BUG: Docker 2014 image download failure is silent #24

tbirdso opened this issue Dec 7, 2022 · 2 comments
Assignees
@tbirdso

Comments

@tbirdso
Copy link
Collaborator

tbirdso commented Dec 7, 2022 •
edited
Loading

A bad manylinux2014-x64 tag was provided for download in an ITKSplitComponents Linux Python test run but the run was marked as successful anyways, even though wheels were missing.

https://github.com/InsightSoftwareConsortium/ITKSplitComponents/actions/runs/3632771768/jobs/6129000489

TODO:

  • Add a sanity check to ensure that each expected wheel is in dist/ before upload to PyPI. If all expected wheels are not build then the run should fail and nothing should upload.
  • Investigate docker option to immediately fail and exit out if image cannot be retrieved.
@tbirdso tbirdso self-assigned this Dec 7, 2022
@tbirdso tbirdso mentioned this issue Dec 7, 2022
Merged
@tbirdso
Copy link
Collaborator Author

tbirdso commented Jan 9, 2023

Observed in ITKElastix _2_28-x64: https://github.com/InsightSoftwareConsortium/ITKElastix/actions/runs/3875435896/jobs/6607971812

@tbirdso
Copy link
Collaborator Author

tbirdso commented Jan 28, 2023

xref #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbirdso tbirdso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbirdso