BUG: Revert to valid manylinux2014-x64 image tag
#240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `manylinux_2_28` and `manylinux2014` images are typically tagged together, a recent `manylinux_2_28` release addressing a _2_28 toolset compatibility issue was not paired with a `manylinux2014` release. This commit updates Linux build scripts to decouple the tag used for each image. See also: https://hub.docker.com/u/dockcross
|
This issue was not caught because docker failed silently in ITKSplitComponents in the most recent tag bump, will open an issue in ITKRemoteModuleBuildTestPackageAction to ensure that a docker failure results in a failed job. |
|
Seeing successful ITKSplitComponents 2014 builds with changes applied: https://github.com/InsightSoftwareConsortium/ITKSplitComponents/actions/runs/3642021820/jobs/6148645321 |
dzenanz
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
manylinux_2_28andmanylinux2014images are typically tagged together, a recentmanylinux_2_28release addressing a _2_28 toolset compatibility issue was not paired with amanylinux2014release. This commit updates Linux build scripts to decouple the tag used for each image.See also: https://hub.docker.com/u/dockcross