View 2D: IJK slicing #137
Merged
View 2D: IJK slicing #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewtex
reviewed
May 21, 2024
| @@ -80,7 +80,7 @@ function inflate(bounds: Bounds, delta: number) { | |||
| } | |||
|
|
|||
| // code modified from vtk.js/ImageData | |||
| const extentToBounds = (ex: Extent, indexToWorld: mat4) => { | |||
| const extentToBounds = (ex: Extent, indexToWorld: ReadonlyMat4) => { | |||
| @@ -129,7 +129,8 @@ const extentToBounds = (ex: Extent, indexToWorld: mat4) => { | |||
| return bounds; | |||
| }; | |||
|
|
|||
| export const ensure3dDirection = (d: Float64Array): ReadonlyMat3 => { | |||
| // returns a copy | |||
| export const ensure3dDirection = (d: Float64Array): mat3 => { | |||
Avoids 3d reset in viewport from overriding 2d reset in view-2d if timing is strange
thewtex
reviewed
Jun 4, 2024
Comment on lines
186
to
187
| type Maybe2dVec = | ||
| | [number, number] |
There was a problem hiding this comment.
Please add a longer description comment
thewtex
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #133