-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View 2D: IJK slicing #137
View 2D: IJK slicing #137
Conversation
@@ -80,7 +80,7 @@ function inflate(bounds: Bounds, delta: number) { | |||
} | |||
|
|||
// code modified from vtk.js/ImageData | |||
const extentToBounds = (ex: Extent, indexToWorld: mat4) => { | |||
const extentToBounds = (ex: Extent, indexToWorld: ReadonlyMat4) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ex -> extent
@@ -129,7 +129,8 @@ const extentToBounds = (ex: Extent, indexToWorld: mat4) => { | |||
return bounds; | |||
}; | |||
|
|||
export const ensure3dDirection = (d: Float64Array): ReadonlyMat3 => { | |||
// returns a copy | |||
export const ensure3dDirection = (d: Float64Array): mat3 => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d -> direction (?)
Avoids 3d reset in viewport from overriding 2d reset in view-2d if timing is strange
type Maybe2dVec = | ||
| [number, number] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a longer description comment
Related issue #133