feat: provide createWebWorker #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re: #1018 |
thewtex
force-pushed
the
create-web-worker
branch
from
fd5abbf
to
fa30f9c
Compare
PaulHax
approved these changes
Dec 24, 2023
There was a problem hiding this comment.
Cool. A step to removing this benign error causing "tee up" of a pipeline in VolView:
https://github.com/Kitware/VolView/blob/main/src/io/dicom.ts#L69-L79
To "prime the pump" for the .wasm asset, should VolView just fetch() its custom .wasm file? Is there another possible speedup by asking the browser to "load" the .wasm?
| const outputs = null | ||
| const inputs = null | ||
| const stdoutStderrPath = 'stdout-stderr-test' | ||
| const { returnValue, stdout, stderr } = await itk.runPipeline(webWorker, stdoutStderrPath, args, outputs, inputs, { pipelineWorkerUrl }) |
There was a problem hiding this comment.
Is { pipelineWorkerUrl } option still needed?
I made a note to investigate this more in #1018 |
So compatible web workers can be created explicitly when desired.
thewtex
force-pushed
the
create-web-worker
branch
from
fa30f9c
to
923726e
Compare
thewtex
merged commit b52eab7
into
InsightSoftwareConsortium:main
83 of 109 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So compatible web workers can be created explicitly when desired.