Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loadPipelineModule): load pipeline once #1034

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented Jan 2, 2024

Presently, calling loadPipelineModule multiple times with the same pipeline in quick succession will cause multiple network requests to go out to fetch the pipeline code. This change coalesces multiple calls into a single pipeline fetch.

@floryst floryst requested a review from thewtex January 2, 2024 22:28
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @floryst !

@thewtex
Copy link
Member

thewtex commented Jan 3, 2024

Failing tests unrelated.

@thewtex thewtex merged commit 7659865 into main Jan 3, 2024
213 of 219 checks passed
@thewtex thewtex deleted the floryst-patch-1 branch January 3, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants