feat(BrowserAPI): Return and accept the web worker used for computation #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables re-use of the web worker or calling `terminate()` on the worker to free resources. We also fix a bug -- previously only a single worker was being used by the app. BREAKING CHANGE: Calls to the browser API must now pass null or a previously generated web worker as their first argument. The browser API function now return objects with a `webWorker` member.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables re-use of the web worker or calling
terminate()on the worker to free resources. Wealso fix a bug -- previously only a single worker was being used by the
app.
BREAKING CHANGE: Calls to the browser API must now pass null or a previously generated web worker as
their first argument. The browser API function now return objects with a
webWorkermember.