fix: Run update-versions during prepublishOnly npm step #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
FezVrasta
reviewed
Oct 11, 2022
thewtex
force-pushed
the
prepublish-update-versions
branch
from
0c1c38e
to
930f3a7
Compare
Get the version from package.json, which should be set by semantic-release.
thewtex
force-pushed
the
prepublish-update-versions
branch
from
930f3a7
to
8717d05
Compare
|
@thewtex Were you able to verify this will work with a dry run? |
|
@floryst Yes, locally with |
|
I would presume that semantic-release will have written out the correct version by the prepublish step. |
floryst
approved these changes
Oct 12, 2022
|
🎉 This PR is included in version 1.0.0-b.40 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
thewtex
added a commit
to thewtex/itk-wasm
that referenced
this pull request
Oct 21, 2022
The dependency on itk-wasm was `itk-wasm@0.0.0-semantically-released` following InsightSoftwareConsortium#668
github-actions bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
# [1.0.0-b.44](itk-wasm-v1.0.0-b.43...itk-wasm-v1.0.0-b.44) (2022-10-21) ### Bug Fixes * **io-packages:** Update with main package semantic-release version ([6e62ba7](6e62ba7)), closes [#668](#668)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the version from package.json, which should be set by semantic-release.