Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support coloring by scalar attributes (point or cell data) on geometries #163

Closed
thewtex opened this issue Jul 17, 2019 · 5 comments · Fixed by #171
Closed

Support coloring by scalar attributes (point or cell data) on geometries #163

thewtex opened this issue Jul 17, 2019 · 5 comments · Fixed by #171
Labels
enhancement New feature or request

Comments

@thewtex
Copy link
Member

thewtex commented Jul 17, 2019

@banesullivan

@thewtex thewtex added the enhancement New feature or request label Jul 17, 2019
@banesullivan
Copy link

ref #154

@banesullivan
Copy link

I'm curious, @thewtex, is this a high priority?

Once this is implemented, I can move forward with adding full support for itk-jupyter-widgets in PyVista rather quickly, which it seems a lot of folks are interested in seeing.

@thewtex
Copy link
Member Author

thewtex commented Jul 22, 2019

Once this is implemented, I can move forward with adding full support for itk-jupyter-widgets in PyVista rather quickly, which it seems a lot of folks are interested in seeing.

That's awesome! I will add initial support as soon as possible (this week) to help you move forward. It will essentially work, but there will be some expected, undesirable behavior -- namely, when visualization parameters, like selection of the color map for scalars, are changed in the interactive browser interface, they will not be updated on the Python side. This will addressed eventually, though.

@banesullivan
Copy link

That sounds fine to me! After all, the PyVista-itkwidgets plotter will be a proof of concept on the first round and then we can refine/refactor it as features are added/fixed.

@banesullivan
Copy link

Thanks for moving so fast on this, @thewtex!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants