Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix like when the "Get the App" bar is visible #47

Merged
merged 3 commits into from
Apr 7, 2017

Conversation

eduardocalazansjr
Copy link
Contributor

Instead of calling Selenium method Click, get the Class of the Like
Button and do a Click() with Javascript.

If there’s an element above the Like Button, Selenium doesn’t hit it
and throw an error, JS don’t.

Instead of calling Selenium method Click, get the Class of the Like
Button and do a Click() with Javascript.

If there’s an element above the Like Button, Selenium doesn’t hit it
and throw an error, JS don’t.
@eduardocalazansjr
Copy link
Contributor Author

Fixes #42

@timgrossmann
Copy link
Collaborator

@vlntdds Insanely smart fix for this problem!
Thank you.

@timgrossmann timgrossmann merged commit 7022d9b into InstaPy:master Apr 7, 2017
converge pushed a commit to converge/InstaPy that referenced this pull request Oct 11, 2017
Fix like when the "Get the App" bar is visible
@blesson3
Copy link

This change was overwritten in the current master commit 7ab3e00 (file w/ line: https://github.com/timgrossmann/InstaPy/blob/master/instapy/like_util.py#L538).

I suspect the overwrite is causing issues that this PR solved to come back up.

@timgrossmann
Copy link
Collaborator

@blesson3 Thank you for pointing out!
Can you double check if it works again now?

@blesson3
Copy link

blesson3 commented Jan 13, 2018

@timgrossmann I ran the script for a while and it seemed to fix the problem with clicking the like button!

I see that you overwrote that line above to what the PR changed it to, see below why I don't think the solution is that easy in this case. https://github.com/timgrossmann/InstaPy/commit/ad6e579b56b464698cd13b01faca18291f639659
(https://github.com/timgrossmann/InstaPy/blob/master/instapy/like_util.py#L538)

Now I'm running into another issue similar, but different:

except: Message: unknown error: Element <a href="/explore/tags/sun/?max_id=1691136460033415146" class="_1cr2e _epyes">...</a> is not clickable at point (381, 340). Other element would receive the click: <div class="_eyflt">...</div>
  (Session info: chrome=63.0.3239.132)
  (Driver info: chromedriver=2.34.522913 (36222509aa6e819815938cbf2709b4849735537c),platform=Linux 4.4.0-53-generic x86_64)

See the following issue for discussion: https://github.com/timgrossmann/InstaPy/issues/1232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants