Adding space to new comment just before typing it on screen. #6343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
When trying to make a comment, mentioning someone with the @ character at the end of the comment was causing a bug, in which the bot seemed to work just fine, but didn't really "hit enter" to actually comment the post. Very specific right? But it was my use case, and the use case of some other people too. This was happening because when you type @ username on a comment, an account list menu appears. So if you press enter after that, you don't submit the comment, you actually just confirm the account mention instead.
Adding space to the new comment just before typing it on screen makes no difference for normal comments, and avoids this bug. It's a small fix to a big problem :)
Fixes # (issue)
#6296 Not posting the comment when mentioning any account.
How Has This Been Tested?
I've tested it to use it myself in a personal project. It's very simple to test, and works just fine. No unit tests are needed.
I also think that this could be merged into master too, but I'd rather first send it to dev, because I didn't find any guidelines on how I should be making this PR, so I took a more conservative approach.
Perhaps you could add more specific guidelines for PRs somewhere in the future :)
Checklist:
black -t py34
Happy Hacktoberfest!