Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding space to new comment just before typing it on screen. #6343

Merged
merged 2 commits into from
Oct 10, 2021
Merged

Adding space to new comment just before typing it on screen. #6343

merged 2 commits into from
Oct 10, 2021

Conversation

GabrielaBezerra
Copy link

Pull Request Template

Description

When trying to make a comment, mentioning someone with the @ character at the end of the comment was causing a bug, in which the bot seemed to work just fine, but didn't really "hit enter" to actually comment the post. Very specific right? But it was my use case, and the use case of some other people too. This was happening because when you type @ username on a comment, an account list menu appears. So if you press enter after that, you don't submit the comment, you actually just confirm the account mention instead.

Adding space to the new comment just before typing it on screen makes no difference for normal comments, and avoids this bug. It's a small fix to a big problem :)

Fixes # (issue)

#6296 Not posting the comment when mentioning any account.

How Has This Been Tested?

I've tested it to use it myself in a personal project. It's very simple to test, and works just fine. No unit tests are needed.

  • Test

I also think that this could be merged into master too, but I'd rather first send it to dev, because I didn't find any guidelines on how I should be making this PR, so I took a more conservative approach.
Perhaps you could add more specific guidelines for PRs somewhere in the future :)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings
  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project, black -t py34
  • My changes generate no new warnings

Happy Hacktoberfest!

@elulcao elulcao linked an issue Oct 10, 2021 that may be closed by this pull request
@elulcao elulcao merged commit f2134e6 into InstaPy:dev Oct 10, 2021
@Wenz-W
Copy link

Wenz-W commented Oct 14, 2021

Pull Request Template

Description

When trying to make a comment, mentioning someone with the @ character at the end of the comment was causing a bug, in which the bot seemed to work just fine, but didn't really "hit enter" to actually comment the post. Very specific right? But it was my use case, and the use case of some other people too. This was happening because when you type @ username on a comment, an account list menu appears. So if you press enter after that, you don't submit the comment, you actually just confirm the account mention instead.

Adding space to the new comment just before typing it on screen makes no difference for normal comments, and avoids this bug. It's a small fix to a big problem :)

Fixes # (issue)

#6296 Not posting the comment when mentioning any account.

How Has This Been Tested?

I've tested it to use it myself in a personal project. It's very simple to test, and works just fine. No unit tests are needed.

  • Test

I also think that this could be merged into master too, but I'd rather first send it to dev, because I didn't find any guidelines on how I should be making this PR, so I took a more conservative approach. Perhaps you could add more specific guidelines for PRs somewhere in the future :)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings
  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project, black -t py34
  • My changes generate no new warnings

Happy Hacktoberfest!

Oi Gabi =P,
I tried it today and it's not working anymore, it's like it was before, it writes but doesn't publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not posting the comment when mentioning any account.
3 participants