Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INSD-9704] Fix The onInvoke Callback #369

Merged
merged 3 commits into from Jun 21, 2023
Merged

[INSD-9704] Fix The onInvoke Callback #369

merged 3 commits into from Jun 21, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Jun 16, 2023

Description of the change

The BugReporting.setOnInvokeCallback API breaks the Instabug.show API because the on-invoke doesn't get called on the main thread which causes the native Android SDK to produce the following error:

E/IBG-Core(22608): Instabug failed to execute {Instabug.show} due toMethods marked with @UiThread must be executed on the main thread. Current thread: IBG-API-executor-0

This PR fixes this issue by running the on-invoke callback for Flutter on the main thread.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev requested a review from asamiz June 16, 2023 12:43
@a7medev a7medev self-assigned this Jun 16, 2023
@InstabugCI
Copy link
Collaborator

InstabugCI commented Jun 16, 2023

Coverage Report

Label Coverage Status
Dart 83.7%

Generated by 🚫 dangerJS against b24aa00

Copy link
Contributor

@asamiz asamiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an approval from me, good job as always @a7medev.

@a7medev a7medev merged commit 1a46bb2 into dev Jun 21, 2023
10 checks passed
@a7medev a7medev deleted the fix/on-invoke branch June 21, 2023 15:18
HeshamMegid pushed a commit that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants