Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new session replay apis #395

Merged
merged 16 commits into from Sep 28, 2023
Merged

feat: add new session replay apis #395

merged 16 commits into from Sep 28, 2023

Conversation

abdelhamid-f-nasser
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser commented Sep 24, 2023 •
edited

Description of the change

  • Add new session replay APIs
  • Unit test the session replay APIs

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

Depends on

@abdelhamid-f-nasser abdelhamid-f-nasser marked this pull request as draft September 24, 2023 15:54
@InstabugCI
Copy link
Collaborator

InstabugCI commented Sep 24, 2023 •
edited

Coverage Report

Label Coverage Status
Dart 85.8% ✅

Generated by 🚫 dangerJS against 094433f

@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the feat/add-new-session-replay-apis branch 2 times, most recently from f4b9c6e to 2362be7 Compare September 25, 2023 10:14
@abdelhamid-f-nasser abdelhamid-f-nasser changed the base branch from chore/bump-android-sdk-12.0.1 to chore/bump-android-sdk-12.1.0 September 25, 2023 10:19
@abdelhamid-f-nasser abdelhamid-f-nasser marked this pull request as ready for review September 25, 2023 17:59
@a7medev a7medev changed the base branch from chore/bump-android-sdk-12.1.0 to feat/add-new-session-replay-for-repro-steps-api September 26, 2023 13:24
a7medev
a7medev requested changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @abdelhamid-f-nasser! 👏🏼 Just a few tweaks and we're ready to go!

android/src/test/java/com/instabug/flutter/SessionReplayApiTest.java Outdated Show resolved Hide resolved
lib/src/modules/session_replay.dart Outdated Show resolved Hide resolved
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the feat/add-new-session-replay-for-repro-steps-api branch from 059d8ab to 3e3e848 Compare September 26, 2023 13:52
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the feat/add-new-session-replay-apis branch 2 times, most recently from 930c825 to 150da8b Compare September 26, 2023 15:11
@a7medev a7medev force-pushed the feat/add-new-session-replay-for-repro-steps-api branch from 3e3e848 to 1047530 Compare September 27, 2023 07:43
Base automatically changed from feat/add-new-session-replay-for-repro-steps-api to dev September 27, 2023 16:31
@a7medev a7medev force-pushed the feat/add-new-session-replay-apis branch from 150da8b to 1f088fb Compare September 27, 2023 16:36
@a7medev a7medev self-requested a review September 28, 2023 11:58
a7medev
a7medev requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdelhamid-f-nasser Everything looks great. We just need to add Dart tests for the new Session Replay module in the test directory.

a7medev
a7medev requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change and we're good to go! 🚀

test/session_replay_test.dart Outdated Show resolved Hide resolved
@a7medev a7medev self-requested a review September 28, 2023 13:32
@a7medev a7medev merged commit db27c6e into dev Sep 28, 2023
9 of 10 checks passed
@a7medev a7medev deleted the feat/add-new-session-replay-apis branch September 28, 2023 13:32
HeshamMegid pushed a commit that referenced this pull request Sep 28, 2023
@abdelhamid-f-nasser @HeshamMegid
feat: add new session replay apis (#395)
a095f31 
Jira ID: MOB-13047, IBGCRASH-20007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

@asamiz asamiz Awaiting requested review from asamiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abdelhamid-f-nasser @InstabugCI @a7medev