Skip to content

Commit

Permalink
fix(ios): enable screenshots for crashes & sessions (#1055)
Browse files Browse the repository at this point in the history
  • Loading branch information
abdelhamid-f-nasser committed Nov 13, 2023
1 parent 1e375ac commit 8ab4902
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

- Fix an issue with Android Gradle Plugin namespace support required for React Native 0.73 and backward compatibility with previous versions ([#1044](https://github.com/Instabug/Instabug-React-Native/pull/1044)).
- Fix an issue with unhandled JavaScript crashes being reported as native iOS crashes ([#1054](https://github.com/Instabug/Instabug-React-Native/pull/1054))
- Re-enable screenshot capturing for Crash Reporting and Session Replay by removing redundant mapping ([#1055](https://github.com/Instabug/Instabug-React-Native/pull/1055)).

## [12.1.0](https://github.com/Instabug/Instabug-React-Native/compare/v12.1.0...v11.14.0)

Expand Down
9 changes: 0 additions & 9 deletions src/modules/Instabug.ts
Original file line number Diff line number Diff line change
Expand Up @@ -328,15 +328,6 @@ export const setReproStepsConfig = (config: ReproConfig) => {
sessionReplay = config.all;
}

// There's an issue with crashes repro steps with screenshots in the iOS SDK
// at the moment, so we'll map enabled with screenshots to enabled with no
// screenshots to avoid storing the images on disk if it's not needed until
// this issue is fixed in a future version.
if (Platform.OS === 'ios' && crash === ReproStepsMode.enabled) {
/* istanbul ignore next */
crash = ReproStepsMode.enabledWithNoScreenshots;
}

NativeInstabug.setReproStepsConfig(bug, crash, sessionReplay);
};

Expand Down

0 comments on commit 8ab4902

Please sign in to comment.