Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): enable screenshots for crashes & sessions #1055

Merged
merged 2 commits into from
Nov 13, 2023
Merged

fix(ios): enable screenshots for crashes & sessions #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2b4eae
fix: enable iOS screenshot capture for SR and CR
abdelhamid-f-nasser Nov 9, 2023
aa031ce
docs: update changelog.md
abdelhamid-f-nasser Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

- Fix an issue with Android Gradle Plugin namespace support required for React Native 0.73 and backward compatibility with previous versions ([#1044](https://github.com/Instabug/Instabug-React-Native/pull/1044)).
- Fix an issue with unhandled JavaScript crashes being reported as native iOS crashes ([#1054](https://github.com/Instabug/Instabug-React-Native/pull/1054))
- Re-enable screenshot capturing for Crash Reporting and Session Replay by removing redundant mapping ([#1055](https://github.com/Instabug/Instabug-React-Native/pull/1055)).

## [12.1.0](https://github.com/Instabug/Instabug-React-Native/compare/v12.1.0...v11.14.0)

Expand Down
9 changes: 0 additions & 9 deletions src/modules/Instabug.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,15 +328,6 @@ export const setReproStepsConfig = (config: ReproConfig) => {
sessionReplay = config.all;
}

// There's an issue with crashes repro steps with screenshots in the iOS SDK
// at the moment, so we'll map enabled with screenshots to enabled with no
// screenshots to avoid storing the images on disk if it's not needed until
// this issue is fixed in a future version.
if (Platform.OS === 'ios' && crash === ReproStepsMode.enabled) {
/* istanbul ignore next */
crash = ReproStepsMode.enabledWithNoScreenshots;
}

NativeInstabug.setReproStepsConfig(bug, crash, sessionReplay);
};

Expand Down