Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add contributing to fixit page #113

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

jimmylai
Copy link
Contributor

@jimmylai jimmylai commented Sep 4, 2020

Summary

add contributing to fixit page

Test Plan

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 4, 2020

Coding Style
------------
We use flake8, isort and black to enforce coding style.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and fixit rules? :D


Our Development Process
=======================
This github repo is the source of truth and all changes need to be reviewed in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
This github repo is the source of truth and all changes need to be reviewed in
This GitHub repo is the source of truth and all changes need to be reviewed in

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe link to repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This github repo is the source of truth and all changes need to be reviewed in
This `GitHub repo <https://github.com/Instagram/Fixit>`_ is the source of truth and all changes need to be reviewed in

@jimmylai jimmylai merged commit b29c337 into Instagram:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants