Sentinel type error #187
Merged
Sentinel type error #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Consider updating requirements.txt to also depend on libcst>=0.3.18, where this name was added. |
jimmylai
reviewed
Apr 23, 2021
fixit/common/autofix.py
Outdated
Comment on lines
177
to
179
| if isinstance(replacement_node, cst.RemovalSentinel): | ||
| if isinstance(replacement_node, cst.RemovalSentinel) or isinstance( | ||
| replacement_node, cst.FlattenSentinel | ||
| ): |
There was a problem hiding this comment.
tox -e autofix should fix the lint warning on this line.
There was a problem hiding this comment.
Can you add python -m fixit.cli.apply_fix {posargs:.} to the autofix target and then run it?
https://github.com/Instagram/Fixit/blob/master/tox.ini#L28-L34
That can make future development easier.
There was a problem hiding this comment.
tox -e autofix actually does not fix this line, which is strange. I'll update it by hand and add it to the tox.ini though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pyre is broken on master due to changes in the latest version of LibCST. This fixes by adding
cst.FlattenSentinelto some function calls.#186
Test Plan
pyre --preserve-pythonpath check