Demonstrate fixme comments that are not being respected #413
Conversation
|
Hi @samueljsb! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
samueljsb
changed the title
samueljsb
force-pushed
the
405-lint-fixme-comments-not-respected
branch
from
ea50956
to
a3099fd
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
amyreese
force-pushed
the
405-lint-fixme-comments-not-respected
branch
from
a3099fd
to
3bb7dd2
Compare
Adds logic to `LintRule.node_comments()` looking for directives in more locations relative to the current node: - trailing inline comments after commas - preceding and trailing comments inside brackets - preceding comments before/after decorators for classes and functions In addition, to better support suppressions for decorators themselves, the logic to break upward searching until reaching a `leading_lines` node has been modified to exclude `Decorator` nodes which have their own leading lines that aren't used for the first decorator on a class. Based on code examples reported in Instagram#413
amyreese
force-pushed
the
405-lint-fixme-comments-not-respected
branch
from
3bb7dd2
to
adbd956
Compare
Add a failing test to demonstrate decorator comment not respected Add failing test to demonstrate comprehension comments not respected Add failing test to demonstrate list element comments not respected More test cases, label and split existing cases Co-authored-by: Amethyst Reese <amethyst@n7.gg>
amyreese
force-pushed
the
405-lint-fixme-comments-not-respected
branch
from
adbd956
to
5c1b514
Compare
Adds logic to `LintRule.node_comments()` looking for directives in more locations relative to the current node: - trailing inline comments after commas - preceding and trailing comments inside brackets - preceding comments before/after decorators for classes and functions In addition, to better support suppressions for decorators themselves, the logic to break upward searching until reaching a `leading_lines` node has been modified to exclude `Decorator` nodes which have their own leading lines that aren't used for the first decorator on a class. Based on code examples reported in #413 ghstack-source-id: 4907870d9ecde15fd1110b3d276bc7f95569c513 Pull Request resolved: #441
Summary
Test Plan
Failing tests have been added to demonstrate (most of) the bugs reported in #405. I have not been able to add one for the function definition problem because there are cases in this test that need to define functions without errors, so I can't just report
functionDef.