Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix scrollToObject: bug when scrolling to bottom with content inset
Summary: This has been around forever, surprised we've never run into it. Instagram doesn't really use the `bottom` position except for one place that is already at the bottom of a view. Looks like this bug has just been hanging around quietly for ages. `UIScrollView` takes into account the content inset when changing the content offset. Doing math w/ the inset is both useless and incorrect. Issue fixed: #932 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes #940 Differential Revision: D5881117 Pulled By: rnystrom fbshipit-source-id: 5c9af4b6f8b59be977491ba734e9b0fa3c538cb9
- Loading branch information
1 parent
595c09e
commit b2860c3
Showing
3 changed files
with
31 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters