Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permanently disable the "Merge" PR button #399

Closed
rnystrom opened this issue Jan 9, 2017 · 8 comments
Closed

Permanently disable the "Merge" PR button #399

rnystrom opened this issue Jan 9, 2017 · 8 comments
Labels

Comments

@rnystrom
Copy link
Contributor

rnystrom commented Jan 9, 2017

Talking w/ @orta this weekend we had an idea:

Since we want to disable anyone from ever clicking the merge button, how about we setup a simple service and use the GH status API to return state: failure for every single PR? No logic, no nothing, just fail every PR. That way we can stick to using our internal tools and add collaborators w/out having to warn ppl (sorry @Sherlouk @zhubofei 😅 ).

W/ the setup we have, I don't think there is ever a need to click that button.

@Sherlouk
Copy link
Contributor

Sherlouk commented Jan 9, 2017

Don't have write access anyway, so can't press it even if I wanted to!

Sounds like an easy solution to the problem though

@rnystrom
Copy link
Contributor Author

rnystrom commented Jan 9, 2017

@Sherlouk 🤔 you should have write-access

@Sherlouk
Copy link
Contributor

Sherlouk commented Jan 9, 2017

@rnystrom I just see this: http://prntscr.com/dth4xm (Buttons are disabled)

@rnystrom
Copy link
Contributor Author

rnystrom commented Jan 9, 2017

Hm interesting. I wonder if our tooling messed something up. Going to check internal settings and see what's up there.

@Sherlouk
Copy link
Contributor

Sherlouk commented Jan 9, 2017

Assumed it was intentional to stop me pressing it!

@zhubofei
Copy link

zhubofei commented Jan 9, 2017

I can confirm that the Merge Button was clickable to me for a really short period two days ago and then went grey.

@Sherlouk
Copy link
Contributor

@rnystrom We have #394 which is to use Danger for automated PR verification, could we just add a fail clause for every pull request which is "Merges must be done internally"?

Saves having another service bound to the repo?

@rnystrom
Copy link
Contributor Author

@Sherlouk totally agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants