Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New guide for UICollectionView (follow-up to #409) #527

Closed
jessesquires opened this issue Mar 6, 2017 · 6 comments
Closed

New guide for UICollectionView (follow-up to #409) #527

jessesquires opened this issue Mar 6, 2017 · 6 comments
Assignees
Milestone

Comments

@jessesquires
Copy link
Contributor

In light of #409, we should publish updates to the Guides, or maybe a new guide?

Proposal, new guide:

Working with UICollectionView

Thoughts?

@jessesquires jessesquires added this to the 3.0.0 milestone Mar 6, 2017
@jessesquires jessesquires self-assigned this Mar 6, 2017
@jessesquires
Copy link
Contributor Author

cc @rnystrom

@rnystrom
Copy link
Contributor

Also prefetchingEnabled = NO, using UIAppearance trick is cool too

@weyert
Copy link
Contributor

weyert commented Mar 16, 2017

Sorry, why is prefetchingEnabled = NO wasn't this one of the hot new features of iOS 10 announce last year at WWDC?

@rnystrom
Copy link
Contributor

rnystrom commented Mar 16, 2017

@weyert yup, it was. However we've run some testing and show that by simply being enabled this feature causes serious scroll performance regressions.

That is, if prefetchingEnabled = YES and don't even have a prefetchDataSource set, your app will scroll much worse.

IGListKit doesn't use this feature (we have our own "working range" implementation that is similar), so recommend always disabling it.

@weyert
Copy link
Contributor

weyert commented Mar 17, 2017

Ah, makes sense. Thanks for clarifying it, @rnystrom

@jessesquires
Copy link
Contributor Author

PR up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants