Fix mutating array datasource bug #1109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessesquires
approved these changes
Feb 22, 2018
jessesquires
suggested changes
Feb 22, 2018
|
@KashishGoel responding to the Test question here. Actually think a Test would be awesome for the longevity of this fix! Would be really easy:
You can init a new SC without setting up the rest of the IGLK infra even. Sent with GitHawk |
|
@KashishGoel has updated the pull request. View: changes |
|
@KashishGoel has updated the pull request. View: changes |
|
@rnystrom Added a test, should be enough to ensure we don't run into this problem again. |
|
@KashishGoel its perfect 😇 |
There was a problem hiding this comment.
@rnystrom is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Copy objects when retrieving from datasource to account for the edge case where the returned data is a mutable array.
Issue fixed: #999
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.