Fix scrollToObject: inconsistency bug when scrolling to bottom/right with content inset #1284
Conversation
…lDirection:scrollPosition:animated:]` where the content inset(bottom/right) of the collection view was incorrectly being applied to the final offset and was inconsistent with the content inset(top/left) of the collection view being applied. [Qinghua Hong](https://github.com/xohozu)
Generated by 🚫 Danger |
|
Hi, @rnystrom , I can not figure out why the travis-ci task failed while my local building and testing are passed. Could you please check whether some common mistakes occurred? |
There was a problem hiding this comment.
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@qhhonx has updated the pull request. Re-import the pull request |
@rnystrom Can you reimport this PR again? It just fixes testcase inconsistency without extra logic code. |
|
@lorixx It seems that you are active maintainer now. Can you review this PR and import it again? |
There was a problem hiding this comment.
@bdotdub has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Just realized #1284 had an extraneous `else` block. This just cleans that up
Summary: Just realized #1284 had an extraneous `else` block. This just cleans that up ## Changes in this pull request See above ### Checklist - [X] All tests pass. Demo project builds and runs. - [X] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [X] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: #1325 Reviewed By: timonus Differential Revision: D15511564 Pulled By: timonus fbshipit-source-id: c21213ee6ccc06ffb0b646381cba3faff0347144
The implementation of
has little inconsistencies where the
UICollectionViewScrollPositionLeftandUICollectionViewScrollPositionTopconsidering the content inset left/top of the collection view was being applied to the final offset. However, theUICollectionViewScrollPositionRightandUICollectionViewScrollPositionBottomignoring the content inset right/bottom of the collection view was being applied to the final offset. The different result is that scrolling to the mostLeft/Top, the first section content always be visible by considering its content inset while scrolling to the mostRight/Bottom, the last section content always be fully displayed but not be fully visible by considering its content inset.Changes in this pull request
Issue fixed: #
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.