Fix inconsistent state caused in UICollectionViewLayout+InteractiveReordering. #1289
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Generated by 🚫 Danger |
ofirgluzman
force-pushed
the
interactive-reordering-fix-inconsistent-state
branch
from
90f2f77
to
43d24ba
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
…InteractiveReordering.
ofirgluzman
force-pushed
the
interactive-reordering-fix-inconsistent-state
branch
from
43d24ba
to
95799c7
Compare
| XCTAssertEqual(section1, [self.adapter sectionControllerForSection:0]); | ||
| XCTAssertEqual(section2, [self.adapter sectionControllerForSection:2]); | ||
| } | ||
|
|
There was a problem hiding this comment.
Thank you for adding tests!
There was a problem hiding this comment.
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…ordering. (Instagram#1289) Summary: Issue fixed: Instagram#1288 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: Instagram#1289 Reviewed By: timonus Differential Revision: D13590406 Pulled By: rnystrom fbshipit-source-id: 0814b0c2383a185da747176bad57dfb15c7e883f
Changes in this pull request
Issue fixed: #1288
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.