Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert NSUInteger to NSInteger #440

Closed
wants to merge 1 commit into from
Closed

Convert NSUInteger to NSInteger #440

wants to merge 1 commit into from

Conversation

zhubofei
Copy link

Changes in this pull request

#431

Pull request checklist

  • All tests pass. Demo project builds and runs.

No breaking changes that I am aware of.

@zhubofei zhubofei closed this Jan 22, 2017
@zhubofei zhubofei reopened this Jan 22, 2017
@zhubofei zhubofei added this to the 2.2.0 milestone Jan 22, 2017
@zhubofei
Copy link
Author

Nothing is breaking. IMHO, we can push this one in 2.2.0.

@facebook-github-bot
Copy link
Contributor

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zhubofei zhubofei deleted the uint-to-int branch January 22, 2017 22:45
jessesquires pushed a commit that referenced this pull request Jan 23, 2017
@bofeizhu @jessesquires
Convert NSUInteger to NSInteger
2ceda10 
Summary:
- [x] All tests pass. Demo project builds and runs.

No breaking changes that I am aware of.
Closes #440

Differential Revision: D4448496

Pulled By: rnystrom

fbshipit-source-id: 9ad9bc3734b605ceab25bf6cdf993568aa6561c1
@jessesquires
Copy link
Contributor

jessesquires commented Feb 10, 2017 •
edited
Loading

Wait -- doesn't this change the Swift APIs when this is bridged?

cc @rnystrom @zhubofei

@rnystrom
Copy link
Contributor

@jessesquires should all be internal changes

@zhubofei
Copy link
Author

@jessesquires There's no public API changes in this PR.

@jessesquires
Copy link
Contributor

ah right 👍

facebook-github-bot pushed a commit that referenced this pull request Feb 11, 2017
@jessesquires @facebook-github-bot
fix integer type inconsistency, potential over/underflow
7d55bd8 
Summary:
Internal crash reports (see T15774792) indicate we're having integer overflow/underflow issues.
I notcied this inconsistency, which was introduced by GH issues #431, #440.

Differential Revision: D4546852

fbshipit-source-id: 67e56487cce02f082943f3008bcfcb5cf6205e0e
@jessesquires jessesquires modified the milestones: 2.2.0, 3.0.0 Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zhubofei @facebook-github-bot @jessesquires @rnystrom @bofeizhu