Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent negative spaces for items and supplementaries #583

Closed
wants to merge 2 commits into from
Closed

Prevent negative spaces for items and supplementaries #583

wants to merge 2 commits into from

Conversation

rnystrom
Copy link
Contributor

@rnystrom rnystrom commented Mar 24, 2017 •
edited
Loading

Changes in this pull request

If a negative height/width comes down, cap it to 0.0.

Issue fixed: #566

Also fixes t16455632 internally.

Checklist

  • All tests pass. Demo project builds and runs.
  • I added tests, an experiment, or detailed why my change isn't tested.
  • I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.

@facebook-github-bot
Copy link
Contributor

@rnystrom updated the pull request - view changes

@rnystrom
Copy link
Contributor Author

@jessesquires lmk if good to land?

@rotemdoron
Copy link

@rnystrom hi again guys, i tried to install the negative-size branch, becouse im having the crash issue in here #566, but i dont have the reload methods there, should i use master instead? are you guys merging it?

@jessesquires jessesquires added this to the 3.0.0 milestone Mar 27, 2017
jessesquires
jessesquires approved these changes Mar 27, 2017
View reviewed changes
Copy link
Contributor

@jessesquires jessesquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@facebook-github-bot
Copy link
Contributor

@jessesquires has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@rnystrom
Copy link
Contributor Author

@rotemdoron this is based off of master which moved reload methods from IGListCollectionContext into a context object used in performUpdatesAnimated:. See a15ea08

@jessesquires jessesquires deleted the negative-sizes branch March 30, 2017 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesquires jessesquires jessesquires approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Don't allow returning negative sizes for cells and supplementary views
4 participants
@rnystrom @facebook-github-bot @rotemdoron @jessesquires