Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installing rustc/cargo for mybinder demo #1083

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

aleivag
Copy link
Contributor

@aleivag aleivag commented Jan 2, 2024

Summary

when we switch to the rust compiler by default, mybinder stop working, as reported in #1054 this is because the binder docker image does not have a rust compiler or tools, this install them by using the apt.txt file

Test Plan

if you go to https://mybinder.org/v2/gh/aleivag/LibCST/fix-binder?filepath=docs/source/tutorial.ipynb you'll see this works

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 2, 2024
@aleivag
Copy link
Contributor Author

aleivag commented Jan 2, 2024

notice that this just fix the binder docker image creation... I think this is still missing installing python dependencies like typing_inspect , i plan to fix that part in a subsequent PR

EDIT: actually fixed in this PR

when we switch to the rust compiler by default, mybinder stop working, as reoported in Instagram#1054 this is because the binder docker image does not have a rust compiler or tools, this install them by using the apt.txt file
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52bbff6) 91.09% compared to head (2060dfb) 91.09%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1083   +/-   ##
=======================================
  Coverage   91.09%   91.09%           
=======================================
  Files         255      255           
  Lines       26564    26564           
=======================================
  Hits        24198    24198           
  Misses       2366     2366           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zsol zsol merged commit 1757e0f into Instagram:main Jan 3, 2024
24 checks passed
@zsol
Copy link
Member

zsol commented Jan 3, 2024

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants