Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FullRepoManager cache property #330

Merged
merged 2 commits into from
Jul 6, 2020
Merged

FullRepoManager cache property #330

merged 2 commits into from
Jul 6, 2020

Conversation

josieesh
Copy link
Contributor

@josieesh josieesh commented Jul 3, 2020 •
edited

Summary

A need for the ability to fetch cache for all paths at once became evident in a use case requiring some optimizations.
The ability to access the private _cache property of FullRepoManager would be useful in a case like this.

Test Plan

  • Test case in test_full_repo_manager
  • All tests pass

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2020
@josieesh josieesh mentioned this pull request Jul 3, 2020
Merged
@josieesh josieesh marked this pull request as ready for review July 6, 2020 12:46
jimmylai
jimmylai approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@jimmylai jimmylai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josieesh josieesh merged commit 8523852 into Instagram:master Jul 6, 2020
@josieesh josieesh deleted the frm_cache branch July 6, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmylai jimmylai jimmylai approved these changes

@zsol zsol Awaiting requested review from zsol

@mvismonte mvismonte Awaiting requested review from mvismonte

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josieesh @jimmylai @facebook-github-bot