[scope] Visit concatenated f-strings #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
* pin linter versions * fix lint errors
…ope-concat-strings
jimmylai
approved these changes
Nov 5, 2020
Comment on lines
130
to
131
| assert isinstance(b_referent, Assignment) # for the typechecker's eyes | ||
| self.assertEqual(b_referent.node, import_node) |
There was a problem hiding this comment.
nit: can we do this instead? We usually don't use assert because it's a noop in optimized mode.
if isinstance(b_referent, Assignment):
self.assertEqual(b_referent.node, import_node)
There was a problem hiding this comment.
sure, but it doesn't matter much because there's a
self.assertIsInstance(b_referent, Assignment)
right above it, so if the assertion fails, no further code will be executed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes sure scope analysis visits nodes under a
ConcatenatedString. This is important becauseConcatenatedStrings may containFormattedStrings which can contain further expressions. We only need to go deeper if the concatenated string is not part of a type annotation though (those can't contain f-strings).Fixes #410.
Test Plan
Added unit test.