Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pyo3 >=0.17 #957

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Allow pyo3 >=0.17 #957

merged 2 commits into from
Jun 14, 2023

Conversation

apbard
Copy link
Contributor

@apbard apbard commented Jun 14, 2023

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 14, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (50d48c1) 90.92% compared to head (0081d7e) 90.92%.

❗ Current head 0081d7e differs from pull request most recent head 841afac. Consider uploading reports for the commit 841afac to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #957   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files         254      254           
  Lines       25962    25962           
=======================================
  Hits        23607    23607           
  Misses       2355     2355           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zsol
Copy link
Member

zsol commented Jun 14, 2023

Thanks <3

@zsol zsol merged commit a3f5bf9 into Instagram:main Jun 14, 2023
23 checks passed
@zsol zsol changed the title Bump pyo3 to 0.18 Allow pyo3 >=0.17 Jun 14, 2023
@zertosh
Copy link

zertosh commented Jun 20, 2023

@zsol, isn't this going to bite you later on when there really is a breaking change? Remember that there are no semver guarantees in 0.x. I think you probably mean to have here at least ">=0.17, <=0.19" or at most ">=0.17, <1".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants