Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't gather dirs ending .py #994

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Don't gather dirs ending .py #994

merged 1 commit into from
Aug 26, 2023

Conversation

kit1980
Copy link
Contributor

@kit1980 kit1980 commented Aug 24, 2023

Summary

codemod.gather_files should not try to gather dirs those names ending with .py, only regular files
(the issue encountered in an actual codebase).

Test Plan

libcst/tests/test_e2e.py updated

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9eab2f0) 90.93% compared to head (8b62f45) 90.93%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #994   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         254      254           
  Lines       25974    25976    +2     
=======================================
+ Hits        23619    23621    +2     
  Misses       2355     2355           
Files Changed Coverage Δ
libcst/codemod/_cli.py 57.77% <ø> (ø)
libcst/tests/test_e2e.py 97.61% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 24, 2023
@kit1980
Copy link
Contributor Author

kit1980 commented Aug 24, 2023

The CI errors look unrelated:

Error: Cache folder path is retrieved for pip but doesn't exist on disk: /home/runner/.cache/pip

@zsol
Copy link
Member

zsol commented Aug 26, 2023

Thanks!

@zsol zsol merged commit 0f7766f into Instagram:main Aug 26, 2023
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants