Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

fix collection of enums not being parsed #60

Closed
wants to merge 1 commit into from

Conversation

aimango
Copy link
Contributor

@aimango aimango commented Jun 30, 2020

Summary:

  • Enums in igjsonparser are currently supported via FromJson annotation. We were supporting them fine for singular instances, but for collections of enums, we were not wrapping the extracted rValue with the FromJson adapter method.
  • Fixing that up here by just moving the wrapping logic inside of generateExtractRvalue which is used for both Lists and Maps.

Differential Revision: D22285285

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22285285

@ttung
Copy link
Contributor

ttung commented Jun 30, 2020

No tests? :(

Summary:
Pull Request resolved: Instagram#60

- Enums in igjsonparser are currently supported via `FromJson` annotation. We were supporting them fine for singular instances, but for collections of enums, we were not wrapping the extracted rValue with the `FromJson` adapter method.
- Fixing that up here by just moving the wrapping logic inside of `generateExtractRvalue` which is used for both Lists and Maps.

Differential Revision: D22285285

fbshipit-source-id: 5063eb4b702ce7a2c73c8ca899efab367085c0f8
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D22285285

@aimango aimango mentioned this pull request Jul 1, 2020
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c18b38b.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants