This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
fix collection of enums not being parsed #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D22285285 |
|
No tests? :( |
Summary: Pull Request resolved: Instagram#60 - Enums in igjsonparser are currently supported via `FromJson` annotation. We were supporting them fine for singular instances, but for collections of enums, we were not wrapping the extracted rValue with the `FromJson` adapter method. - Fixing that up here by just moving the wrapping logic inside of `generateExtractRvalue` which is used for both Lists and Maps. Differential Revision: D22285285 fbshipit-source-id: 5063eb4b702ce7a2c73c8ca899efab367085c0f8
aimango
force-pushed
the
export-D22285285
branch
from
b3047ef
to
aa74719
Compare
|
This pull request was exported from Phabricator. Differential Revision: D22285285 |
Closed
|
This pull request has been merged in c18b38b. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
FromJsonannotation. We were supporting them fine for singular instances, but for collections of enums, we were not wrapping the extracted rValue with theFromJsonadapter method.generateExtractRvaluewhich is used for both Lists and Maps.Differential Revision: D22285285