Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update googlechromepkg.sh #1366

Closed
wants to merge 1 commit into from
Closed

Conversation

jshtux
Copy link
Contributor

@jshtux jshtux commented Dec 8, 2023

omahaproxy is permanently shutdown; must use google api service to get current version now

omahaproxy is permanently shutdown; must use google api service to get current version now
@fraserhess
Copy link
Contributor

curl -s https://versionhistory.googleapis.com/v1/chrome/platforms/mac_arm64/channels/stable/versions | plutil -extract versions.0.version raw -o - - would be more elegant but I'm figuring that macOS Monterey can't be assumed

@jshtux
Copy link
Contributor Author

jshtux commented Dec 20, 2023 via email

@meschwartz
Copy link
Contributor

Just came here to see if there was a PR yet for this. This was my solution:

appNewVersion=$(getJSONValue "$(curl -fsL 'https://chromiumdash.appspot.com/fetch_releases?channel=Stable&platform=Mac&num=1' )" "[0].version" )

@jshtux
Copy link
Contributor Author

jshtux commented Dec 27, 2023 via email

@fraserhess
Copy link
Contributor

I'm still researching an alternative, but all of the approaches suggested so far have a problem: they pick up early stable release versions. The current version returned is 121.0.6167.75 which has a 0.25% rollout. That does not match with the pkg download URL. 121.x isn't scheduled for a full stable release until the 23rd.

Screenshot 2024-01-18 at 11 53 37

https://chromiumdash.appspot.com/schedule
https://chromereleases.googleblog.com/2024/01/early-stable-for-desktop.html

@fraserhess
Copy link
Contributor

ok, I've reverse-engineered what https://chromeenterprise.google/browser/download/#mac-tab does, and here's my new proposal:
appNewVersion=$(getJSONValue "$(curl -fsL "https://versionhistory.googleapis.com/v1/chrome/platforms/mac/channels/stable/versions/all/releases?filter=fraction>0.1,endtime=none&order_by=version%20desc" )" "releases[0].version" )

API reference: https://developer.chrome.com/docs/web-platform/versionhistory/reference

@meschwartz
Copy link
Contributor

Wow, well done!

@BigMacAdmin
Copy link
Collaborator

Can someone make a final pull request with the agreed upon best solution? @fraserhess ?

@BigMacAdmin BigMacAdmin self-assigned this Mar 12, 2024
@BigMacAdmin BigMacAdmin added application adds or improves an application label waiting for response labels Mar 12, 2024
@jshtux
Copy link
Contributor Author

jshtux commented Mar 12, 2024

my pull request can be cancelled; it looks like @fraserhess has the best solution as it is what the browser itself uses

@mjabroux
Copy link

Sorry to comment on a closed PR but it looks like
appNewVersion=$(getJSONValue "$(curl -fsL "https://versionhistory.googleapis.com/v1/chrome/platforms/mac/channels/stable/versions/all/releases?filter=fraction>0.1,endtime=none&order_by=version%20desc" )" "releases[0].version" ) might not be giving the latest stable new version.
@drtaru was kind enough to help me on this and the following filter might resolve this as it gives us the latest Chrome version.
appNewVersion=$(getJSONValue "$(curl -fsL "https://versionhistory.googleapis.com/v1/chrome/platforms/mac/channels/stable/versions/all/releases?filter=fraction>=0.1,endtime=none&order_by=version%20desc" )" "releases[0].version" )

@fraserhess
Copy link
Contributor

fraserhess commented Mar 20, 2024

Yes, I can see that versions do not match. Looking at Google's JS again I think the filter should be for a fraction greater than 1% instead of 10%

appNewVersion=$(getJSONValue "$(curl -fsL "https://versionhistory.googleapis.com/v1/chrome/platforms/mac/channels/stable/versions/all/releases?filter=fraction>0.01,endtime=none&order_by=version%20desc" )" "releases[0].version" )

AymenAbb added a commit to AymenAbb/Installomator that referenced this pull request Mar 21, 2024
Agreed upon solution requested by @BigMacAdmin as provided by @fraserhess and @mjabroux from Installomator#1366. Didn't see anyone else doing a PR on this and it's been a bit.
AymenAbb added a commit to AymenAbb/Installomator that referenced this pull request Mar 26, 2024
Agreed upon solution requested by @BigMacAdmin as provided by @fraserhess and @mjabroux from Installomator#1366. Didn't see anyone else doing a PR on this and it's been a bit. Second commit due to my mistake on Installomator#1556
@scriptingosx scriptingosx added help wanted Extra attention is needed application-requested labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application adds or improves an application label application-requested help wanted Extra attention is needed waiting for response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants