Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an extra parameter to script #50

Closed
wants to merge 1 commit into from
Closed

Added an extra parameter to script #50

wants to merge 1 commit into from

Conversation

Theile
Copy link
Collaborator

@Theile Theile commented Jul 9, 2020

I would like to override BLOCKING_PROCESS_ACTION=prompt_user, so an extra parameter will do that.

I would like to override BLOCKING_PROCESS_ACTION=prompt_user, so an extra parameter will do that.
@scriptingosx scriptingosx added the argument-refactor refactor how arguments are parsed label Jul 22, 2020
@scriptingosx scriptingosx added this to the v0.4 milestone Jul 22, 2020
@Raptor399
Copy link
Contributor

I'd say apply the same logic to all three major configuration settings: DEBUG, NOTIFY as well as BLOCKING_PROCCESS_ACTION. You'd want to configure these as script parameters in Jamf without having to change the source code.

@scriptingosx
Copy link
Collaborator

I have started working on a more generalized version of this in the argument-refactor branch.

The changes i did so far now allow to provide and override variables in the form VAR=value as an argument:

% ./Installomator.sh NOTIFY=silent BLOCKING_PROCESS-ACTION=ignore desktoppr

all the variables as arguments have to be provided before the label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argument-refactor refactor how arguments are parsed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants