Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/166 improved ux ui home mobile tablet #188

Merged
merged 5 commits into from May 6, 2020

Conversation

Abibibi
Copy link
Collaborator

@Abibibi Abibibi commented May 5, 2020

To make sure form is visible as soon as possible when arriving on homepage.

Fold is now on both mobile and tablet:

  • to make as much space as possible for form
  • because UX-wise, it still makes more sense to put instructions before form

newTabletHomeUI
newPhoneHomeUI

@Abibibi Abibibi requested review from HugoGresse and ntchou May 5, 2020 22:55
@Abibibi Abibibi force-pushed the enhancement/166-improved-ux-ui-home-mobile-tablet branch from a540693 to d4a515a Compare May 5, 2020 22:58
Copy link
Member

@HugoGresse HugoGresse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can maybe remove the yarn.lock, still nothing much to change for me in the PR.

@@ -11,5 +11,5 @@ export default function useDetectMobile() {
window.removeEventListener('resize', handleResize)
}
}, [])
return width < 768
return width < 1180
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to edit the function for useDetectMobileOrTablet?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ! it's now edited :)

@Abibibi Abibibi merged commit 8aae8bc into master May 6, 2020
@Abibibi Abibibi deleted the enhancement/166-improved-ux-ui-home-mobile-tablet branch May 6, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants