<list> fix: Prevent rendering items from nested <list>
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter list of items with those that have the current list instance as a parent.
flochtililoch
force-pushed
the
florent/nested-lists
branch
from
1ce8953
to
6ea3404
Compare
adamstep
reviewed
May 28, 2021
…t child node of `<list>`
|
Would it relatively easy to add unit tests to account for all of these cases? |
I'll take a look. I think I'll have to refactor it to isolate the code so that I can mock elements |
adamstep
approved these changes
Jun 1, 2021
flochtililoch
pushed a commit
that referenced
this pull request
Jun 10, 2021
Follow up for #312. One scenario with paginated lists was not accounted correctly. A paginated list could typically look like this: ```xml <list> <item>1</item> <item>2</item> <items> <item>3</item> <item>4</item> <items> <item>5</item> <item>6</item> <items> ... </items> </items> </items> </list> ``` Previous implementation did not account for recursive nesting aspect of `<items>`, and would only retrieve the items under the `<items>` directly nested under the main `<list>`. This fixes it by recursively checking that the parent list is the same as our current element.
Merged
flochtililoch
pushed a commit
that referenced
this pull request
Jun 10, 2021
Follow up for #312. One scenario with paginated lists was not accounted correctly. A paginated list could typically look like this: ```xml <list> <item>1</item> <item>2</item> <items> <item>3</item> <item>4</item> <items> <item>5</item> <item>6</item> <items> ... </items> </items> </items> </list> ``` Previous implementation did not account for recursive nesting aspect of `<items>`, and would only retrieve the items under the `<items>` directly nested under the main `<list>`. This fixes it by recursively checking that the parent list is the same as our current element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render list items that are direct children of the
<list>element, or nested under a<items>children node.