Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hyperview app expo template #815

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

Tobi-De
Copy link

@Tobi-De Tobi-De commented Feb 14, 2024

Working on a template for hyperview starter

I got some issues with the dependencies, I had to use the --force option

pm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: expo-template-hyperview@1.0.0
npm ERR! Found: @types/react@18.2.55
npm ERR! node_modules/@types/react
npm ERR!   dev @types/react@"~18.2.45" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @types/react@"^17.0.67" from hyperview@0.75.0
npm ERR! node_modules/hyperview
npm ERR!   hyperview@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Most of the dependencies suggested here #451 had a similar issue

The barebone hyperview also have this issue #550
The app header merger with the phone app bar

But I've got to say, Hyperview has really come a long way. You guys are doing a great job. A single Hyperview component to get the basics working and connected to a backend, lovely.

@Tobi-De
Copy link
Author

Tobi-De commented Feb 14, 2024

@flochtililoch I understand that you need a deployed package to specify a template, but do you have any idea how Expo identifies a template? Perhaps a link to the docs on this? I think my current layout won't work; maybe it needs a specific name for the folder of the template?

@Tobi-De
Copy link
Author

Tobi-De commented Feb 14, 2024

Does it make sense to copy the tsconfig.json from the demo ? I feel like yes

{
  "extends": "@tsconfig/react-native/tsconfig.json",
  "compilerOptions": {
    "checkJs": false,
    "paths": {
      "hyperview/*": ["./node_modules/hyperview/*"]
    }
  },
  "exclude": ["**/*.js", "**/*.jsx"]
}

@flochtililoch
Copy link
Collaborator

I'm not sure if this is necessary or whether expo already provides with a tsconfig.json file when initializing the app skeleton. I think some of what we have in the demo config are legacy and no longer needed. It's probably worth trying to start without and see if there's any issues getting the generated app running.

@Tobi-De
Copy link
Author

Tobi-De commented Feb 14, 2024

I'm not sure if this is necessary or whether expo already provides with a tsconfig.json file when initializing the app skeleton. I think some of what we have in the demo config are legacy and no longer needed. It's probably worth trying to start without and see if there's any issues getting the generated app running.

Ok, it run, the only issues are what I mentionned above

@flochtililoch
Copy link
Collaborator

@flochtililoch I understand that you need a deployed package to specify a template, but do you have any idea how Expo identifies a template? Perhaps a link to the docs on this? I think my current layout won't work; maybe it needs a specific name for the folder of the template?

Sorry I missed this earlier. I haven't done it myself, but found this:
https://github.com/expo/fyi/blob/main/prebuild-without-npm-access.md#using-a-template-from-github

which might help addressing this specific issue:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: expo-template-hyperview@1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants