chore: update @react-native-picker/picker #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgray-instawork
force-pushed
the
hardin/update-picker
branch
from
9128ba8
to
9ee1486
Compare
flochtililoch
approved these changes
Mar 4, 2024
# Conflicts: # demo/package.json # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating @react-native-picker/picker from 2.4.0 to 2.6.1
yarnyarnin demoOn Android, starting after v2.5.1, an issue occurs where a zero font size is used for the picker. See notes: react-native-picker/picker#536
Upgrading Expo seems to resolve the issue. However, we decided that it would be better to include a fix in our wrapper.
<Picker.item>Illustration of bug: https://github.com/Instawork/hyperview/assets/127122858/71029ef9-c335-4ef1-bdcb-ef3272dac9b5
Asana: https://app.asana.com/0/0/1206718044236459/f