Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior): add support for prefetch action #892

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

palaparthi
Copy link
Contributor

Add support for new action called prefetch, this will fetch an URL in the background.
Offline mode(built internally at Instawork) will take advantage of this by prefetching the necessary screens and saving them in the cache.

Copy link
Collaborator

@hgray-instawork hgray-instawork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in scope for this but I wonder if the behaviors should receive the entire onUpdateCallbacks object?

@palaparthi
Copy link
Contributor Author

Not in scope for this but I wonder if the behaviors should receive the entire onUpdateCallbacks object?

I thought about it too but decided otherwise since that needed a refactor but I agree with you.

@flochtililoch suggested that this is probably better suited as a custom behavior since this is not documented/available for public use. I will park the PR for now and come back to this later once I have offline write stuff working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants